Skip to content

[rc2] Fix temporal table versioning when removing default constraints from columns#36667

Merged
AndriySvyryd merged 8 commits intorelease/10.0from
copilot/fix-35631
Aug 29, 2025
Merged

[rc2] Fix temporal table versioning when removing default constraints from columns#36667
AndriySvyryd merged 8 commits intorelease/10.0from
copilot/fix-35631

Conversation

Copy link
Contributor

Copilot AI commented Aug 27, 2025 •
edited by AndriySvyryd
Loading

Fixes #35631

Description
When using SQL Server temporal tables, removing a DEFAULT constraint failed as this requires versioning to be temporarily disabled.

Customer impact
Customers would get an exception when applying a migration that removes a DEFAULT constraint. Workarounds include avoiding removing DEFAULT constraints and disabling versioning manually.

How found
Customer reported on EF9.

Regression
Yes, from EF8.

Testing
Added test Temporal_table_with_default_constraint_can_alter_column that verifies temporal tables with DEFAULT constraints can have their columns altered successfully. Also added tests for other facets including HasDefaultValueSql.

Risk
Low. The change only affects migrations on temporal tables.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@AndriySvyryd
Fix DEFAULT constraint being applied to temporal history tables
d7a6c83 
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title [WIP] Migration applies DEFAULT constraint on SqlServer temporal history table Fix DEFAULT constraint being applied to SQL Server temporal history tables Aug 27, 2025
Copilot AI requested a review from AndriySvyryd August 27, 2025 01:52
AndriySvyryd
AndriySvyryd approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Rewrite the PR summary using this template:

Fixes #{number}

**Description**
{Issue description}

**Customer impact**
{How does the reported issue affects customer's app? Are there workarounds?}

**How found**
{Was it customer reported or found during verification? How many customers are affected?}

**Regression**
{Is it a regression from a released version? Which one?}

**Testing**
{How the changes were tested}

**Risk**
{Low/Medium/High, argument why}

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 27, 2025

@copilot Continue

@AndriySvyryd
Add test for temporal table default constraint fix
e61598d 
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 27, 2025 •
edited
Loading

@copilot Rewrite the PR summary using this template:

...

Here's the PR summary rewritten using the template:

Fixes #35631

Description
When using SQL Server temporal tables, DEFAULT constraints were incorrectly being applied to both the main table and the history table during migrations. This caused subsequent column alterations to fail with constraint dependency errors like "The object 'DF__AHistory__Name__5DCAEF64' is dependent on column 'Name'". History tables in SQL Server temporal tables should not have DEFAULT constraints since they only store historical data and don't accept direct inserts.

Customer impact
Customers using SQL Server temporal tables with DEFAULT constraints on columns cannot perform subsequent migrations that alter those columns. The migration fails with a SqlException about constraint dependencies. Workarounds include manually dropping DEFAULT constraints from history tables before running migrations or avoiding DEFAULT constraints on temporal table columns entirely.

How found
This was customer reported via issue #35631. The issue affects any customer using SQL Server temporal tables with DEFAULT constraints who then tries to alter column properties in subsequent migrations.

Regression
This appears to be a long-standing issue in the temporal table implementation rather than a recent regression.

Testing
Added test Temporal_table_with_default_constraint_can_alter_column that verifies temporal tables with DEFAULT constraints can have their columns altered successfully. The fix was also manually verified to resolve the specific scenario described in the issue.

Risk
Low - The change is surgical and only affects the specific scenario where DEFAULT constraints were being incorrectly copied to history table operations. It preserves all other necessary annotations for proper history table operation.

@copilot Continue

Completed the requested tasks:

  1. ✅ Added test for the DEFAULT constraint fix (commit e61598d)
  2. ✅ Rewrote PR summary using the provided template format

The fix modifies CopyColumnOperation in SqlServerMigrationsSqlGenerator.cs to exclude RelationalAnnotationNames.DefaultConstraintName when copying annotations to history table operations, ensuring DEFAULT constraints are only applied to the main temporal table.

Copilot AI requested a review from AndriySvyryd August 27, 2025 22:46
@AndriySvyryd
Fix temporal table default constraint removal to disable versioning
bc51f0d 
Modified AlterColumnOperation handling to detect when default values are being
removed and disable versioning in that case. Updated test to remove default
value in target model and adjusted expected SQL output.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
@AndriySvyryd
Add additional tests for temporal table column facet modifications
996ea21 
Added tests for adding default constraints and changing default constraint
values on temporal table columns to provide comprehensive coverage of
default constraint handling scenarios.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title Fix DEFAULT constraint being applied to SQL Server temporal history tables Fix temporal table versioning when removing default constraints from columns Aug 27, 2025
@AndriySvyryd AndriySvyryd changed the title Fix temporal table versioning when removing default constraints from columns [rc2] Fix temporal table versioning when removing default constraints from columns Aug 27, 2025
@AndriySvyryd AndriySvyryd marked this pull request as ready for review August 27, 2025 23:30
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner August 27, 2025 23:30
@AndriySvyryd AndriySvyryd requested a review from artl93 August 27, 2025 23:30
@AndriySvyryd
Refactor temporal table tests to use common setup and add HasDefaultV…
1870d5c 
…alueSql test

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI requested a review from AndriySvyryd August 27, 2025 23:55
artl93
artl93 approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low risk, customer reported

roji
roji approved these changes Aug 28, 2025
View reviewed changes
@AndriySvyryd @roji
Update src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerato…
8d1fbe6 
…r.cs

Co-authored-by: Shay Rojansky <roji@roji.org>
@AndriySvyryd AndriySvyryd enabled auto-merge (squash) August 28, 2025 23:55
@AndriySvyryd AndriySvyryd merged commit 04a4fd7 into release/10.0 Aug 29, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the copilot/fix-35631 branch August 29, 2025 00:36
Copilot AI mentioned this pull request Feb 5, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji approved these changes

@artl93 artl93 artl93 approved these changes

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

Assignees

@AndriySvyryd AndriySvyryd

Copilot code review Copilot

Labels

ask-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migration applies DEFAULT constraint on SqlServer temporal history table

4 participants

@AndriySvyryd @roji @artl93